Support wrangler2 - v2 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregBrimble
reviewed
May 5, 2022
GregBrimble
reviewed
May 6, 2022
|
LGTM! 🙏 |
eidam
reviewed
May 6, 2022
eidam
reviewed
May 6, 2022
petebacondarwin
requested changes
May 9, 2022
There was a problem hiding this comment.
Nice update @WalshyDev - I think the action should still support setting the environment.
README.md
Outdated
| with: | ||
| apiToken: ${{ secrets.CF_API_TOKEN }} | ||
| command: publish | ||
| ``` | ||
|
|
||
| If you need help defining the correct cron syntax, check out [crontab.guru](https://crontab.guru/), which provides a friendly user interface for validating your cron schedule. | ||
|
|
||
| ### Deploying on a "dispatched" event |
There was a problem hiding this comment.
I think that mentioning dispatch event here at all is an implementation concern.
Instead what the user wants to do here is trigger a deploy manually...
Suggested change
| ### Deploying on a "dispatched" event | |
| ### Manually triggering a deployment |
WalshyDev
force-pushed
the
walshy/pages-996-support-wrangler2
branch
from
00dd53d
to
5c36a64
Compare
WalshyDev
force-pushed
the
walshy/pages-996-support-wrangler2
branch
from
5c36a64
to
3c8fc21
Compare
WalshyDev
commented
May 9, 2022
GregBrimble
reviewed
May 9, 2022
GregBrimble
approved these changes
May 9, 2022
|
By the way, I don't have write access on this repo so I cannot merge or cut a release. @codewithkristian or @eidam would probably need to |
petebacondarwin
approved these changes
May 9, 2022
WalshyDev
force-pushed
the
walshy/pages-996-support-wrangler2
branch
from
c42b80c
to
3d1979c
Compare
deadlypants1973
approved these changes
May 9, 2022
JacobMGEvans
reviewed
May 9, 2022
| To deploy static sites and frontend applications to Workers, check out the documentation for [Workers Sites](https://developers.cloudflare.com/workers/sites). | ||
|
|
||
| Note that this action makes no assumptions about _how_ your project is built! **If you need to run a pre-publish step, like building your application, you need to specify a build step in your Workflow.** For instance, if I have an NPM command called `build`, my workflow YAML might resemble the following: | ||
| You will need to add `account_id = ""` in your `wrangler.toml` file or set `accountId` in this GitHub Action. |
There was a problem hiding this comment.
Improved the error message around this.
|
I can merge it in 30
…On Mon, May 9, 2022 at 11:22 Daniel Walsh ***@***.***> wrote:
By the way, I don't have write access on this repo so I cannot merge or
cut a release.
@codewithkristian <https://github.com/codewithkristian> or @eidam
<https://github.com/eidam> would probably need to
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3NDLG2XHFNRYU6WPSP633VJDRQFANCNFSM5VF4HI5Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whooo! Wrangler 2 is awesome :)
Since this is v2 I did make 2 breaking changes but the migration path is super simple.
publish: truewithcommand: publish.You can see it working for a Worker publish here: https://github.com/WalshyDev/wrangler-action-test/runs/6310845616?check_suite_focus=true
You can see it working for a Pages deployment here: https://github.com/WalshyDev/wrangler-action-test/runs/6327883564?check_suite_focus=true
cc: @GregBrimble @eidam @Ekwuno