Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to 16 #56

Merged
merged 1 commit into from Mar 15, 2022
Merged

Update Node.js to 16 #56

merged 1 commit into from Mar 15, 2022

Conversation

ItalyPaleAle
Copy link
Contributor

This makes it possible to build apps using Node.js 16, which has many new features (and will soon be the LTS version)

@olizilla
Copy link

olizilla commented Jul 7, 2021

This would also fix #59

@asyrique
Copy link

Curious if there's anything that's blocking this PR from being merged? Would be happy to help contribute if there is.

Got bitten by this today because we already use Node v16 locally, and node 12 in the action is still using v1 of the package-lock.json lockfile, while Node v16 ships with NPM 7+ which moves to v2 of the lockfile.

@olizilla
Copy link

Yep, would be great to get this merged or get a timeline on node version support for this action. Any reason not to cut a major release that keeps up whith the current LTS node relase? We're now relying on a fork that simply updates the node version here web3-storage#1

@jontybrook
Copy link

For the benefit of anyone else waiting for this to be merged, I have forked v1.3.0 and published a release "v2.0.0" (bumping major release as this is a major change) that runs on node 16.

Whilst I will not be maintaining this fork, if you need to use node16 in your workflows, you can use our fork carepenny/wrangler-action@2.0.0

For example...

...

     - name: Publish to Cloudflare
        uses: carepenny/wrangler-action@2.0.0
        with:
          apiToken: ${{ secrets.CF_API_TOKEN }}

@felixoi
Copy link

felixoi commented Jan 4, 2022

This is also needed to support javascript modules

@kaseyreed
Copy link

If folks are looking for a way to use a specific node version, you can do so using actions/setup-node@v2 and specifying a no-op command for the build section in your wrangler.toml.

For example:

# wrangler.toml
[build]
command = "echo 'do nothing bc you already built it'"

# your-action.yml
# ....
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
          node-version: '16'
      - run: npm ci && npm run build
      - name: Publish
        uses: cloudflare/wrangler-action@1.3.0
        ...

@eidam eidam self-assigned this Mar 14, 2022
@eidam
Copy link
Contributor

eidam commented Mar 15, 2022

thank you for the contribution all, merging and we will create a new version soon

@eidam eidam merged commit 6f62deb into cloudflare:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants