Add encodeBody and cf to ResponseInit. Adopt builder pattern.
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
commented
May 4, 2024
kflansburg
force-pushed
the
kflansburg/response-init
branch
from
ed96771
to
1405289
Compare
kflansburg
force-pushed
the
kflansburg/response-init
branch
from
1405289
to
5766930
Compare
himikof
reviewed
May 4, 2024
kflansburg
force-pushed
the
kflansburg/response-init
branch
from
d180768
to
cbd0775
Compare
kflansburg
force-pushed
the
kflansburg/response-init
branch
from
cbd0775
to
451fc7f
Compare
kflansburg
commented
May 5, 2024
| @@ -2,7 +2,7 @@ use super::SomeSharedData; | |||
| use futures_util::stream::StreamExt; | |||
There was a problem hiding this comment.
These changes to the other files aren't necessary (there are no breaking changes to Response), but are done to adopt the new builder pattern.
himikof
reviewed
May 6, 2024
kflansburg
force-pushed
the
kflansburg/response-init
branch
from
2a5e771
to
d24cc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands
ResponseInitto support all of the options available in JavaScript. Additionally, the builder pattern is adopted so that users do not have to specify all of these new fields as we add them (breaking change). There are a few questions I want to answer before merging this.Closes #567