Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worker-build not working on windows #226

Merged
merged 1 commit into from Sep 23, 2022
Merged

fix: worker-build not working on windows #226

merged 1 commit into from Sep 23, 2022

Conversation

zebp
Copy link
Collaborator

@zebp zebp commented Sep 19, 2022

No description provided.

@devnought
Copy link

I gave your change a whirl on my local as I'm a Windows user, and have been struggling to build a worker.

wasm-pack wouldn't install due to openssl, but I worked around that via the provided installer at https://rustwasm.github.io/wasm-pack/installer/.

Next up was worker-build not finding that version of wasm-pack. I tried this change, but it still doesn't manage to find it.

Since I know my local is installed, I ended up just forcing the function to return Ok(()) for now to get things rolling.

@zebp
Copy link
Collaborator Author

zebp commented Sep 20, 2022

I gave your change a whirl on my local as I'm a Windows user, and have been struggling to build a worker.

wasm-pack wouldn't install due to openssl, but I worked around that via the provided installer at https://rustwasm.github.io/wasm-pack/installer/.

Next up was worker-build not finding that version of wasm-pack. I tried this change, but it still doesn't manage to find it.

Since I know my local is installed, I ended up just forcing the function to return Ok(()) for now to get things rolling.

Sadly OpenSSL's weirdness is out of scope for this PR, you probably need to use vc-pkg to get the OpenSSL headers so it can be build via Cargo. That's what I did and it was worked fine.

@devnought
Copy link

I agree that's out of scope, just wanted to voice that bit of frustration :)

But I did want to let you know that even with this change, worker-builder still cannot find wasm-pack on my Windows machine.

@zebp zebp merged commit cd400f8 into main Sep 23, 2022
@zebp zebp deleted the zeb/esbuild-windows branch September 23, 2022 19:47
@johnomeara1
Copy link

@devnought I'm having issues with this now. How did you manage to get it to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants