Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logpush null filter results in unexpected end of JSON input #1703

Closed
2 tasks done
sawp-d opened this issue Jun 15, 2022 · 4 comments
Closed
2 tasks done

Logpush null filter results in unexpected end of JSON input #1703

sawp-d opened this issue Jun 15, 2022 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@sawp-d
Copy link
Contributor

sawp-d commented Jun 15, 2022

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

terraform: 1.1.7
cloudflare: 3.17.0 (was using 3.16.0 to create the existing logpush job)

Affected resource(s)

resource cloudflare_logpush_job

Terraform configuration files

resource "cloudflare_logpush_job" "example_job" {
  enabled             = true
  zone_id             = "..."
  name                = "..."
  logpull_options     = "fields=..."
  destination_conf    = "..."
  ownership_challenge = "..."
  dataset             = "..."
}

Debug output

Can provide if necessary - started to run but way too many lines of logs that it broke build :(

Panic output

No response

Expected output

Expected filter = optional, logpush job creation successful

Actual output

For apply/destroy:

Error: error parsing logpush job from resource: unexpected end of JSON input

Steps to reproduce

  1. Create new logpush job without filter attribute -> will fail? Haven't tested yet
  2. Update existing logpush job -> will fail, error message, adds filter = null to state
  3. Try destroying existing logpush job -> will fail, error message

Additional factoids

No response

References

No response

@sawp-d sawp-d added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2022
@github-actions
Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2022
@sawp-d
Copy link
Contributor Author

sawp-d commented Jun 15, 2022

Hi @jacobbednarz! I saw this PR released with the latest provider version and have attempted to fix as it's blocking our code. I'm unable to send the debug logs right now without rearchitecting my code (logs started to become 85K+), is it possible for you to take a look at this?

PR that may have a bug: #1660
PR that may fix? #1704

@cmackenzie1
Copy link
Contributor

fyi: @nuggien

@jacobbednarz
Copy link
Member

closed by cloudflare/cloudflare-go#937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants