Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support for configuring managed_headers #1607

Closed
psyked opened this issue May 9, 2022 · 4 comments · Fixed by #1688
Closed

Feature: Support for configuring managed_headers #1607

psyked opened this issue May 9, 2022 · 4 comments · Fixed by #1688
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@psyked
Copy link

psyked commented May 9, 2022

Current Terraform and Cloudflare provider version

2.27

Description

Managed Transforms do not appear to be a currently supported or documented item in the Terraform provider, but are generally available via the Cloudflare UI and API (https://developers.cloudflare.com/rules/transform/managed-transforms/configure/ / https://api.cloudflare.com/#managed-headers-api-change-state-of-managed-headers)

Use cases

The ability to enabling / disable specific of Managed Transforms via Terraform would be excellent.

Potential Terraform configuration

resource "cloudflare_ruleset" "zone_level_managed_waf" {
  zone_id     = "cb029e245cfdd66dc8d2e570d5dd3322"
  name        = "managed transforms"
  description = "managed transforms ruleset description"
  kind        = "zone"
  phase       = "http_request_transform_managed"

  rules {
    action = "execute"
    action_parameters {
      id = "add_cf-bot-score_header"
    }
    description = "Execute Cloudflare Managed Ruleset on my zone-level phase entry point ruleset"
    enabled = true
  }
}

References

No response

@psyked psyked added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2022
@jacobbednarz jacobbednarz added workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2022
@jacobbednarz
Copy link
Member

i don't think the potential configuration makes sense here as it isn't a ruleset endpoint; this would be best as a new resource (possibly a trasform_rule resource or similar but given the others are rulesets, 🤷 ).

@psyked
Copy link
Author

psyked commented May 10, 2022

@jacobbednarz I'm not precious in any way about the implementation / potential configuration - I am a very much a newbie to Terraform in general so I barely understand what I'm working with most of the time. 😅

@jacobbednarz
Copy link
Member

cloudflare-go has support now via cloudflare/cloudflare-go#923

@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Jun 9, 2022
@github-actions github-actions bot added this to the v3.18.0 milestone Jun 22, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants