Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_access_application resource lacks logo_url field #1133

Closed
danopia opened this issue Jul 21, 2021 · 4 comments · Fixed by #1262
Closed

cloudflare_access_application resource lacks logo_url field #1133

danopia opened this issue Jul 21, 2021 · 4 comments · Fixed by #1262
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@danopia
Copy link
Contributor

danopia commented Jul 21, 2021

Current Terraform and Cloudflare provider version

Terraform v1.0.2
on darwin_amd64
+ provider registry.terraform.io/cloudflare/cloudflare v2.24.0

Description

I'd like to attach a logo to Access applications from the Terraform resource. Logos are accepted by Cloudflare as an arbitrary public URL.

Given that updating the application in the Team Dash recreates all the access policies underneath, using the UI to attach a logo later breaks the TF State and requires a state rm / import sequence.

Use cases

Providing a user-facing logo for an application that is created via Terraform.

Potential Terraform configuration

A new logo_url field probably.

resource "cloudflare_access_application" "my_app" {
  zone_id  = cloudflare_zone.my_zone.id
  name     = "My App"
  domain   = "my-app.${cloudflare_zone.my_zone.zone}"
  type     = "self_hosted"
  logo_url = "https://some-project-site.github.io/logo.png"
}

References

I didn't see any previous comments about logo url.

I don't see logo_url referenced in the API docs however I do see the field returned in the list applications endpoint so I have to assume the modification endpoints accept the field already.

@danopia danopia added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 21, 2021
@jacobbednarz
Copy link
Member

if this isn't yet documented publicly, we don't generally add support as it's not considered stable yet. you're welcome to open a support ticket as it may have just been missed during rollout.

once it's publicly documented, we can add it to cloudflare-go and here.

@jacobbednarz jacobbednarz added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 25, 2021
@danie1sullivan
Copy link

danie1sullivan commented Sep 23, 2021

The parameter is still absent in provider version 3.1.0.

If you create an Access application and attach a policy with Terraform, then change the Logo URL in the web console, Terraform loses the policy and tries to recreate it. For some reason the ID of the policy changes when the URL is updated. Recreating with Terraform fails because a policy with the same precedence already exists.

@danopia
Copy link
Contributor Author

danopia commented Sep 23, 2021

I have also seen that symptom as described in the original text. The webapp seems to do a delete and recreate of the rules any time an application is changed in any point&click operation.

Given that updating the application in the Team Dash recreates all the access policies underneath, using the UI to attach a logo later breaks the TF State and requires a state rm / import sequence.

However I don't have established contact with Cloudflare support so I haven't asked them to update the docs to add this field.

@ouranos
Copy link
Contributor

ouranos commented Oct 6, 2021

However I don't have established contact with Cloudflare support so I haven't asked them to update the docs to add this field.

I've raised a few feature requests with our contact (inc. #1226). I'll keep you posted.
In the meantime, I'm using a custom version of the provider and SDK.
Hopefully, this gets resolved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
4 participants