diff --git a/internal/provider/resource_cloudflare_access_application.go b/internal/provider/resource_cloudflare_access_application.go index 27d4595fdf..f8917b43df 100644 --- a/internal/provider/resource_cloudflare_access_application.go +++ b/internal/provider/resource_cloudflare_access_application.go @@ -65,10 +65,7 @@ func resourceCloudflareAccessApplicationCreate(ctx context.Context, d *schema.Re } if _, ok := d.GetOk("saas_app"); ok { - saasApp, err := convertSaasSchemaToStruct(d) - if err != nil { - return diag.FromErr(err) - } + saasApp := convertSaasSchemaToStruct(d) newAccessApplication.SaasApplication = saasApp } @@ -190,10 +187,7 @@ func resourceCloudflareAccessApplicationUpdate(ctx context.Context, d *schema.Re } if _, ok := d.GetOk("saas_app"); ok { - saasConfig, err := convertSaasSchemaToStruct(d) - if err != nil { - return diag.FromErr(err) - } + saasConfig := convertSaasSchemaToStruct(d) updatedAccessApplication.SaasApplication = saasConfig } diff --git a/internal/provider/schema_cloudflare_access_application.go b/internal/provider/schema_cloudflare_access_application.go index 830af70bbd..f87bd14dd8 100644 --- a/internal/provider/schema_cloudflare_access_application.go +++ b/internal/provider/schema_cloudflare_access_application.go @@ -286,7 +286,7 @@ func convertCORSStructToSchema(d *schema.ResourceData, headers *cloudflare.Acces return []interface{}{m} } -func convertSaasSchemaToStruct(d *schema.ResourceData) (*cloudflare.SaasApplication, error) { +func convertSaasSchemaToStruct(d *schema.ResourceData) *cloudflare.SaasApplication { SaasConfig := cloudflare.SaasApplication{} if _, ok := d.GetOk("saas_app"); ok { SaasConfig.SPEntityID = d.Get("saas_app.0.sp_entity_id").(string) @@ -294,7 +294,7 @@ func convertSaasSchemaToStruct(d *schema.ResourceData) (*cloudflare.SaasApplicat SaasConfig.NameIDFormat = d.Get("saas_app.0.name_id_format").(string) } - return &SaasConfig, nil + return &SaasConfig } func convertSaasStructToSchema(d *schema.ResourceData, app *cloudflare.SaasApplication) []interface{} {