Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check key actually matches when calling Cache#match #246

Closed
mrbbot opened this issue Apr 23, 2022 · 0 comments
Closed

Check key actually matches when calling Cache#match #246

mrbbot opened this issue Apr 23, 2022 · 0 comments
Labels
bug Something isn't working quick win
Milestone
2.9.0

Comments

@mrbbot
Copy link
Contributor

mrbbot commented Apr 23, 2022 •
edited

If a key exists in the cache, Miniflare will always return the matching Response on match(). This is not always correct: we should be calling satisfiesWithoutRevalidation from http-cache-semantics first.

There are also a couple other return cases we should implement: https://developers.cloudflare.com/workers/runtime-apis/cache/#match
@mrbbot mrbbot added the bug Something isn't working label Apr 23, 2022
@mrbbot mrbbot added this to the 2.6.0 milestone Jun 9, 2022
@mrbbot mrbbot modified the milestones: 2.6.0, 2.7.0 Jul 9, 2022
@mrbbot mrbbot modified the milestones: 2.7.0, 2.8.0 Aug 19, 2022
@mrbbot mrbbot modified the milestones: 2.8.0, 2.9.0 Sep 7, 2022
mrbbot added a commit that referenced this issue Sep 13, 2022
@mrbbot
Add support for Range requests to Cache#match, ref #246
9326118
mrbbot added a commit that referenced this issue Sep 13, 2022
@mrbbot
Add support for If-Modified-Since to Cache#match, ref #246
38b821d
@mrbbot mrbbot closed this as completed in 932b537 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working quick win
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
1 participant
@mrbbot