fix marshalling of LogpushJob with no filter #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A LogpushJob with no filter incorrectly marshals the filter as
"{\"where\":{}}"
instead of omitting it.Changing the field to a pointer allows us to test for presence and omit it entirely.
Has your change been tested?
I've added a marshalling test that initially tests the valid and not present cases.
Types of changes
What sort of change does your code introduce/modify?
Checklist: