Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when creating virtual network w/o comment #922

Merged
merged 1 commit into from Jun 7, 2022

Conversation

vavsab
Copy link
Contributor

@vavsab vavsab commented Jun 7, 2022

Description

Comment field is required. At least empty string.
image

API docs are misleading

Has your change been tested?

Creation is covered with unit tests.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Related issues:
cloudflare/terraform-provider-cloudflare#1602

@vavsab vavsab requested a review from jacobbednarz as a code owner June 7, 2022 18:05
@jacobbednarz jacobbednarz merged commit dbe8fc4 into cloudflare:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants