Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tunnel Virtual Network params: #920

Merged
merged 2 commits into from Jun 3, 2022

Conversation

vavsab
Copy link
Contributor

@vavsab vavsab commented Jun 3, 2022

Description

  1. Fix misspelled vnet param
  2. Make default network param required

Docs are misleading.

  1. vnet_name is actually name
    image
    image
  2. is_default is actually required during creation
    Insomnia_YhEvZdfOc6

Has your change been tested?

Covered with unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

#913
cloudflare/terraform-provider-cloudflare#1602

1) Fix misspelled vnet param
2) Make default network param required
@vavsab vavsab requested a review from jacobbednarz as a code owner June 3, 2022 17:58
@jacobbednarz jacobbednarz merged commit 6df9e0b into cloudflare:master Jun 3, 2022
@jacobbednarz
Copy link
Member

thanks, i'll mention to the team the public docs are incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants