Generalize IP lists to lists of arbitrary kind. #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as this is removing a bunch of functionality, we need to first deprecate the old stuff and give folks time to migrate off it before the next major version bump. a simple for the new methods, are you able to check out tunnel_routes and use the struct as parameters approach we've defined in the experimental docs to limit the number of parameters we are passing to methods? |
There are now more list kinds, including `redirect` lists, which we want to support soon. This also deprecates the old IP list API. This new interface should be used in the future.
|
Thanks @jacobbednarz. I've updated the PR based on your comments. |
|
thanks! this is great 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now more list kinds, including
redirectlists, which we want to support soon.