Updating API usage of IPsec tunnels #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic_transit_ipsec_tunnel.go
Outdated
| @@ -16,70 +16,97 @@ const ( | |||
| errMagicTransitIPsecTunnelNotDeleted = "When trying to delete IPsec tunnel, API returned deleted: false" | |||
| ) | |||
|
|
|||
| // MagicTransitIPsecTunnelPskMetadata contains metadata associated with PSK | |||
| type MagicTransitIPsecTunnelPskMetadata struct { | |||
| LastGeneratedOn time.Time `json:"last_generated_on,omitempty"` | |||
There was a problem hiding this comment.
you will want the time.Time to be a pointer
Suggested change
| LastGeneratedOn time.Time `json:"last_generated_on,omitempty"` | |
| LastGeneratedOn *time.Time `json:"last_generated_on,omitempty"` |
lungiman
changed the title
lungiman
force-pushed
the
master
branch
2 times, most recently
from
9d25618
to
c3f6d5f
Compare
|
pending some UI/API changes before we merge this one. |
lungiman
changed the title
We are good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amos Paul amos@cloudflare.com
Description
Cloudflare-go is used by Terraform resource provider for Cloudflare. Updating API calls to Magic Transit IPsec Tunnels to support Terraform.
Has your change been tested?
The changes are mostly w.r.t parsing response objects from API calls to cloudflare. This has been tested using unit tests.
Types of changes
What sort of change does your code introduce/modify?
Checklist: