Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external evaluation as a new access group rule #882

Merged
merged 1 commit into from May 17, 2022

Conversation

Noanan
Copy link

@Noanan Noanan commented May 13, 2022

Description

The new external evaluation access group rule has been added to the Access backend, this PR adds it here for additional support with the Cloudflare lib and terraform.

Has your change been tested?

Integration testing with terraform

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

looks good code wise; just waiting on the public API documentation and we can get this merged.

@jroyal
Copy link
Contributor

jroyal commented May 16, 2022

Due to limitations in how the docs are generated on api.cloudflare.com we don't currently layout how these rules are created. Since its just a new rule type and there really isn't any new public documentation regarding a new api endpoint I think we will be ok. How the rule is defined is very unlikely to change at this point.

@jacobbednarz jacobbednarz merged commit 3b76f1d into cloudflare:master May 17, 2022
@jacobbednarz
Copy link
Member

good enough for me! thanks for this @Noanan 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants