Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunnel: return tunnel token, fix uri #881

Merged
merged 2 commits into from May 12, 2022

Conversation

bradleyglover
Copy link

Description

Update TunnelToken to return the result as a string. Also fixes the uri to start with /

Downstream PR here: cloudflare/terraform-provider-cloudflare#1590 (to be updated)

Has your change been tested?

Tested locally with changes to the terraform provider (see above PR) to verify token result was retrievable and properly set in state.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

jacobbednarz commented May 12, 2022

added a simple test to cover the change here (which would have caught the issue initially)

@jacobbednarz jacobbednarz merged commit 41d9f73 into cloudflare:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants