Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rulesets: add support for http_request_redirect phase and redirect action #930

Merged
merged 1 commit into from Jun 16, 2022

Conversation

piperswe
Copy link
Contributor

@piperswe piperswe commented Jun 14, 2022

Description

The from_list parameter is used in the redirect action (see https://developers.cloudflare.com/rules/bulk-redirects/create-api/#3-create-a-bulk-redirect-rule-via-api), among others.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

we'll also need to add http_request_redirect to the phases to be able to use this. check out #924 for an example of adding this.

@jacobbednarz jacobbednarz changed the title Add support for from_list in rule action parameters rulesets: add support for http_request_redirect phase and redirect action Jun 16, 2022
@jacobbednarz jacobbednarz merged commit 604e5b8 into cloudflare:master Jun 16, 2022
@jacobbednarz
Copy link
Member

i added these changes to get them into the main branch and available for testing with other systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants