Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DCV delegation records #1329

Closed
wants to merge 1 commit into from
Closed

Add missing DCV delegation records #1329

wants to merge 1 commit into from

Conversation

brandonjfordham
Copy link

@brandonjfordham brandonjfordham commented Jul 5, 2023

Description

Add support for DCV Delegation records in Certificate Packs.

Closes #1318

Has your change been tested?

Added a unit test and all tests passed.

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

This change is using publicly documented in cloudflare/api-schemas and relies on stable APIs.

can you please link to where the api-schemas reference to this is?

@@ -0,0 +1,3 @@
```release-note:bug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a bug; it's a new feature so enhancement.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to enhancement.

@brandonjfordham
Copy link
Author

This change is using publicly documented in cloudflare/api-schemas and relies on stable APIs.

can you please link to where the api-schemas reference to this is?

My bad. It is not in the api-schemas reference.

@brandonjfordham brandonjfordham closed this by deleting the head repository Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCV Delegated records are missing for Certification Pack
2 participants