workers: default body to provided payload #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously incorrectly always using `body` (an uninitialised slice of bytes) for the script payload when the configuration was not for an ES module upload. Fixes the upload so that both types are covered.
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 49.40% 49.40%
=======================================
Files 127 127
Lines 12290 12290
=======================================
Hits 6072 6072
Misses 4840 4840
Partials 1378 1378
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
changelog detected ✅ |
|
This functionality has been released in v0.57.1. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
ivan-section-io
pushed a commit
to section/cloudflare-go
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously incorrectly always using
body(an uninitialised slice of bytes) for the script payload when the configuration was not for an ES module upload. Fixes the upload so that both types are covered.