Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Managed networks #1148

Merged
merged 6 commits into from Dec 19, 2022
Merged

Conversation

suhrit-cf
Copy link
Contributor

@suhrit-cf suhrit-cf commented Dec 15, 2022

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Allow users ability to manage managed networks using terraform.

Has your change been tested?

Yes using unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

jacobbednarz commented Dec 15, 2022

can you please update the method signatures to match the experimental client conventions? https://github.com/cloudflare/cloudflare-go/blob/master/docs/experimental.md

you can see an example in #1131

i went ahead and updated this to keep this moving.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #1148 (db74b8d) into master (4ddb00c) will decrease coverage by 0.55%.
The diff coverage is 55.21%.

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   50.11%   49.55%   -0.56%     
==========================================
  Files         121      126       +5     
  Lines       11722    12082     +360     
==========================================
+ Hits         5874     5987     +113     
- Misses       4565     4738     +173     
- Partials     1283     1357      +74     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
errors.go 40.78% <ø> (ø)
pages_deployment.go 34.24% <ø> (-0.24%) ⬇️
pages_domain.go 71.27% <ø> (ø)
pages_project.go 50.81% <ø> (ø)
rulesets.go 35.09% <ø> (ø)
workers_account_settings.go 29.41% <0.00%> (-6.31%) ⬇️
workers_tail.go 52.00% <ø> (ø)
workers_secrets.go 29.41% <28.00%> (-16.05%) ⬇️
workers_cron_triggers.go 29.41% <29.41%> (-16.05%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit f55f495 into cloudflare:master Dec 19, 2022
@github-actions github-actions bot added this to the v0.57.0 milestone Dec 19, 2022
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.57.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants