Update for Functions GA #1136

WalshyDev · 2022-11-30T02:38:44Z

Description

For Functions GA we released a ton of features. This brings the SDK up to date with those.

Docs will be released tomorrow (30th Nov)

Has your change been tested?

Pages project & deployment tests both pass.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
[-] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

github-actions · 2022-11-30T02:40:39Z

changelog detected ✅

codecov-commenter · 2022-11-30T02:41:03Z

Codecov Report

Merging #1136 (3c5cdcc) into master (4ddb00c) will increase coverage by 0.44%.
The diff coverage is 70.35%.

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   50.11%   50.55%   +0.44%     
==========================================
  Files         121      123       +2     
  Lines       11722    11961     +239     
==========================================
+ Hits         5874     6047     +173     
- Misses       4565     4612      +47     
- Partials     1283     1302      +19

Impacted Files	Coverage Δ
device_posture_rule.go	`61.80% <ø> (ø)`
pages_deployment.go	`34.24% <ø> (-0.24%)`	⬇️
pages_domain.go	`71.27% <ø> (ø)`
pages_project.go	`50.81% <ø> (ø)`
r2_bucket.go	`75.67% <40.00%> (-24.33%)`	⬇️
workers.go	`68.64% <43.75%> (-0.74%)`	⬇️
workers_domain.go	`67.18% <67.18%> (ø)`
queue.go	`71.72% <71.72%> (ø)`
workers_kv.go	`55.22% <87.50%> (+0.32%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jacobbednarz · 2022-11-30T06:15:47Z

pages_project.go

-// PagesProjectDeploymentVar represents a deployment environment variable.
-type PagesProjectDeploymentVar struct {
-	Value string `json:"value"`
+	EnvVars                          EnvironmentVariableMap `json:"env_vars,omitempty"`


in a typed language, this is a bit of a code smell. instead of including the type (map) in the name, could we call it EnvVars that expects a []map[string]EnvironmentVariable?

We use these types internally, so I'd personally like to keep this consistent. I can change if you really want though

alright, let's keep them for consistency but the only caveat is once we start looking at codegen'ing the library, this will be changed again to be the concrete type of map[string]*EnvironmentVariable so we'll be inconsistent there once that happens.

jacobbednarz · 2022-11-30T06:53:58Z

pages_project.go

-type PagesProjectDeploymentVar struct {
-	Value string `json:"value"`
+	EnvVars                          EnvironmentVariableMap `json:"env_vars,omitempty"`
+	KvNamespaces                     NamespaceBindingMap    `json:"kv_namespaces,omitempty"`


similar with these types. as we are breaking changes already, can we fix these up?

github-actions · 2022-12-05T21:05:14Z

This functionality has been released in v0.56.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

…7.1 (#6186) BEGIN_COMMIT_OVERRIDE fix(deps): Update module github.com/cloudflare/cloudflare-go to v0.57.1 BREAKING-CHANGE: The deprecated `enabled` column was removed for the `cloudflare_worker_routes` table. See more in https://github.com/cloudflare/cloudflare-go/blob/677a9006b5bf5692981c5a45433315358de9437e/workers.go#L45 END_COMMIT_OVERRIDE This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/cloudflare/cloudflare-go](https://togithub.com/cloudflare/cloudflare-go) | require | minor | `v0.55.0` -> `v0.57.1` | --- ### Release Notes <details> <summary>cloudflare/cloudflare-go</summary> ### [`v0.57.1`](https://togithub.com/cloudflare/cloudflare-go/releases/tag/v0.57.1) [Compare Source](https://togithub.com/cloudflare/cloudflare-go/compare/v0.57.0...v0.57.1) ENHANCEMENTS: - tiered_cache: Add support for Tiered Caching interactions for setting Smart and Generic topologies ([#1149](https://togithub.com/cloudflare/cloudflare-go/issues/1149)) BUG FIXES: - workers: correctly set `body` value for non-ES module uploads ([#1155](https://togithub.com/cloudflare/cloudflare-go/issues/1155)) ### [`v0.57.0`](https://togithub.com/cloudflare/cloudflare-go/releases/tag/v0.57.0) [Compare Source](https://togithub.com/cloudflare/cloudflare-go/compare/v0.56.0...v0.57.0) REAKING CHANGES: - workers: API operations now target account level resources instead of older zone level resources (these are a 1:1 now) ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_bindings: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_cron_triggers: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_kv: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_routes: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_secrets: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers_tails: method signatures have been updated to align with the upcoming client conventions ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) NOTES: - workers: all worker methods have been split into product ownership(-ish) files ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) - workers: all worker methods now require an explicit `ResourceContainer` for endpoints instead of relying on the globally defined `api.AccountID` ([#1137](https://togithub.com/cloudflare/cloudflare-go/issues/1137)) ENHANCEMENTS: - managed_networks: add CRUD functionality for managednetworks ([#1148](https://togithub.com/cloudflare/cloudflare-go/issues/1148)) DEPENDENCIES: - deps: bumps goreleaser/goreleaser-action from 3.2.0 to 4.1.0 ([#1146](https://togithub.com/cloudflare/cloudflare-go/issues/1146)) ### [`v0.56.0`](https://togithub.com/cloudflare/cloudflare-go/releases/tag/v0.56.0) [Compare Source](https://togithub.com/cloudflare/cloudflare-go/compare/v0.55.0...v0.56.0) BREAKING CHANGES: - pages: Changed the type of EnvVars in PagesProjectDeploymentConfigEnvironment & PagesProjectDeployment in order to properly support secrets. ([cloudflare/cloudflare-go#1136) ENHANCEMENTS: - cache_rules: add ignore option to query string struct ([cloudflare/cloudflare-go#1140) - pages: Updates bindings and other Functions related propreties. Service bindings, secrets, fail open/close and usage model are all now supported. ([cloudflare/cloudflare-go#1136) - workers: Support for Workers Analytics Engine bindings ([cloudflare/cloudflare-go#1133) DEPENDENCIES: - deps: bumps github.com/urfave/cli/v2 from 2.23.5 to 2.23.6 ([cloudflare/cloudflare-go#1139) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

WalshyDev added 2 commits November 30, 2022 02:30

Update for Functions GA

3d6d761

Changelog

3c5cdcc

WalshyDev requested a review from jacobbednarz as a code owner November 30, 2022 02:38

jacobbednarz requested changes Nov 30, 2022

View reviewed changes

jacobbednarz merged commit 9023ca8 into cloudflare:master Dec 5, 2022

github-actions bot added this to the v0.56.0 milestone Dec 5, 2022

github-actions bot pushed a commit that referenced this pull request Dec 5, 2022

Update CHANGELOG.md for #1136

1a69cb2

WalshyDev deleted the walshy/pages-2019 branch December 5, 2022 20:07

This was referenced Dec 8, 2022

[Pages] Breaking changes in Cloudflare go cloudflare/terraform-provider-cloudflare#2077

Closed

Pages updates cloudflare/terraform-provider-cloudflare#2083

Merged

ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023

Update CHANGELOG.md for cloudflare#1136

03b7433

renovate bot mentioned this pull request Nov 13, 2023

fix(deps): update module github.com/cloudflare/cloudflare-go to v0.94.0 mailergroup/purge-cf-cache-action#3

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for Functions GA #1136

Update for Functions GA #1136

WalshyDev commented Nov 30, 2022

github-actions bot commented Nov 30, 2022

codecov-commenter commented Nov 30, 2022

jacobbednarz Nov 30, 2022

WalshyDev Nov 30, 2022

jacobbednarz Dec 1, 2022

jacobbednarz Nov 30, 2022

github-actions bot commented Dec 5, 2022

Update for Functions GA #1136

Update for Functions GA #1136

Conversation

WalshyDev commented Nov 30, 2022

Description

Has your change been tested?

Screenshots (if appropriate):

Types of changes

Checklist:

github-actions bot commented Nov 30, 2022

codecov-commenter commented Nov 30, 2022

Codecov Report

jacobbednarz Nov 30, 2022

Choose a reason for hiding this comment

WalshyDev Nov 30, 2022

Choose a reason for hiding this comment

jacobbednarz Dec 1, 2022

Choose a reason for hiding this comment

jacobbednarz Nov 30, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2022