Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workers domain API #1130

Merged
merged 4 commits into from Nov 20, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds support for Workers domain API. Needed for cloudflare/terraform-provider-cloudflare#1921

Has your change been tested?

New tests have been created and pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #1130 (c6a103d) into master (4ddb00c) will increase coverage by 0.07%.
The diff coverage is 67.18%.

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   50.11%   50.19%   +0.07%     
==========================================
  Files         121      122       +1     
  Lines       11722    11801      +79     
==========================================
+ Hits         5874     5923      +49     
- Misses       4565     4585      +20     
- Partials     1283     1293      +10     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
workers_domain.go 67.18% <67.18%> (ø)
r2_bucket.go 75.67% <0.00%> (-24.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

changelog detected ✅

workers_domain.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 3830929 into cloudflare:master Nov 20, 2022
@github-actions github-actions bot added this to the v0.55.0 milestone Nov 20, 2022
github-actions bot pushed a commit that referenced this pull request Nov 20, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.55.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Cyb3r-Jak3 Cyb3r-Jak3 deleted the workers_domains branch June 24, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants