Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-4694 Support Access service token rotation #1120

Merged
merged 1 commit into from Oct 28, 2022

Conversation

veggiedefender
Copy link

Description

Adds the RotateAccessServiceToken function, which is a wrapper for https://api.cloudflare.com/#access-service-tokens-rotate-a-service-token

Has your change been tested?

Automated tests + I tried using it to rotate my own service tokens

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@veggiedefender veggiedefender changed the title Support Access service token rotation AUTH-4694 Support Access service token rotation Oct 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1120 (2179e37) into master (e39278e) will increase coverage by 0.16%.
The diff coverage is 55.94%.

@@            Coverage Diff             @@
##           master    #1120      +/-   ##
==========================================
+ Coverage   49.94%   50.11%   +0.16%     
==========================================
  Files         115      121       +6     
  Lines       10991    11722     +731     
==========================================
+ Hits         5490     5874     +384     
- Misses       4338     4565     +227     
- Partials     1163     1283     +120     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare_experimental.go 0.00% <0.00%> (ø)
device_posture_rule.go 61.80% <ø> (ø)
intelligence_asn.go 64.70% <ø> (ø)
intelligence_domain.go 64.70% <ø> (ø)
pages_project.go 50.81% <ø> (ø)
rulesets.go 35.09% <ø> (ø)
stream.go 64.91% <ø> (ø)
sts.go 0.00% <0.00%> (ø)
teams_accounts.go 53.84% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member

much appreciated @veggiedefender 🙇

@jacobbednarz jacobbednarz merged commit f16565b into cloudflare:master Oct 28, 2022
@github-actions github-actions bot added this to the v0.54.0 milestone Oct 28, 2022
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This functionality has been released in v0.54.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants