Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workers_kv: modernise all methods #1115

Merged
merged 4 commits into from Nov 22, 2022

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Oct 21, 2022

  • Updates the methods to make the experimental client method signatures for consistency
  • Renames some methods to be clearer about what they do
  • Automatically paginate List* requests (except for keys due to potential load issues on larger result sets)

Todo:

  • Add changelog for all method renames/moves

- Updates the methods to make the experimental client method signatures
  for consistency
- Renames some methods to be clearer about what they do
- Automatically paginate List* requests
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #1115 (e3a2edf) into master (4ddb00c) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
- Coverage   50.11%   50.10%   -0.01%     
==========================================
  Files         121      121              
  Lines       11722    11703      -19     
==========================================
- Hits         5874     5864      -10     
+ Misses       4565     4559       -6     
+ Partials     1283     1280       -3     
Impacted Files Coverage Δ
workers_kv.go 55.22% <87.50%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 653ee31 into cloudflare:master Nov 22, 2022
@jacobbednarz jacobbednarz deleted the modernise-workers-kv branch November 22, 2022 21:33
@github-actions github-actions bot added this to the v0.55.0 milestone Nov 22, 2022
github-actions bot pushed a commit that referenced this pull request Nov 22, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.55.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants