Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make request with auth type #1082

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Conversation

23doors
Copy link
Contributor

@23doors 23doors commented Sep 6, 2022

Description

Simple fix for regression introduced in 873a91b

Currently all makeRequestWithAuthType calls (so all origin_ca.go calls) are failing cause it's using api.authType rather then overridden AuthUserService auth type in this case.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1082 (9747807) into master (e39278e) will increase coverage by 0.12%.
The diff coverage is 68.29%.

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   49.94%   50.07%   +0.12%     
==========================================
  Files         115      117       +2     
  Lines       10991    11090      +99     
==========================================
+ Hits         5490     5553      +63     
- Misses       4338     4362      +24     
- Partials     1163     1175      +12     
Impacted Files Coverage Δ
pages_project.go 50.81% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
teams_devices.go 52.63% <ø> (ø)
access_service_tokens.go 66.29% <53.84%> (-2.13%) ⬇️
api_shield.go 53.84% <53.84%> (ø)
url_normalization_settings.go 53.84% <53.84%> (ø)
workers.go 69.38% <72.72%> (-0.04%) ⬇️
cloudflare.go 68.61% <86.95%> (+1.41%) ⬆️
auditlogs.go 53.96% <100.00%> (+2.30%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit d0f7046 into cloudflare:master Sep 6, 2022
@jacobbednarz
Copy link
Member

thanks @23doors! 💯

@github-actions github-actions bot added this to the v0.50.0 milestone Sep 6, 2022
github-actions bot pushed a commit that referenced this pull request Sep 6, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.50.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants