Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_normalization_settings: Add APIs to get and update URL normalizat… #1071

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

tamas-jozsa
Copy link
Contributor

Description

We want to start versioning URL normalization settings in HTTP Applications, so I'm adding these APIs.
The public API implements operations for getting and updating URL normalization settings.
Public API: https://api.cloudflare.com/#url-normalization-properties

Has your change been tested?

I created unit tests and I tested the APIs locally with my account.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

changelog detected ✅

@tamas-jozsa tamas-jozsa force-pushed the tamas/url-normalization-settings branch from 3ae8b17 to e8bb4ce Compare August 30, 2022 11:14
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #1071 (ad96455) into master (e39278e) will increase coverage by 0.09%.
The diff coverage is 67.70%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   49.94%   50.04%   +0.09%     
==========================================
  Files         115      117       +2     
  Lines       10991    11073      +82     
==========================================
+ Hits         5490     5542      +52     
- Misses       4338     4358      +20     
- Partials     1163     1173      +10     
Impacted Files Coverage Δ
pages_project.go 50.81% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
teams_devices.go 52.63% <ø> (ø)
api_shield.go 53.84% <53.84%> (ø)
url_normalization_settings.go 53.84% <53.84%> (ø)
workers.go 69.38% <72.72%> (-0.04%) ⬇️
cloudflare.go 68.42% <93.75%> (+1.21%) ⬆️
email_routing_settings.go 60.00% <100.00%> (ø)
images.go 50.34% <100.00%> (-0.35%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamas-jozsa tamas-jozsa force-pushed the tamas/url-normalization-settings branch from 4b8298b to a7b285e Compare August 30, 2022 11:23
@jacobbednarz jacobbednarz merged commit f7aac0a into master Aug 30, 2022
@jacobbednarz jacobbednarz deleted the tamas/url-normalization-settings branch August 30, 2022 22:51
@github-actions github-actions bot added this to the v0.49.0 milestone Aug 30, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.49.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants