Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content type for JSON is application/json #1049

Merged

Conversation

sodabrew
Copy link
Contributor

@sodabrew sodabrew commented Aug 17, 2022

Description

Tests were using application-json which is not a valid content type. The correct value is application/json. There is no strict parser that catches this, but 👋 :airquotes: there should be :airquotes:

Has your change been tested?

go test . still works

Types of changes

What sort of change does your code introduce/modify?

  • Nit fix (meaningful but nitpicky change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

changelog detected ✅

@sodabrew sodabrew force-pushed the astone/fix-test-content-types branch from 1a17fc9 to 6d33ac3 Compare August 17, 2022 03:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #1049 (6d33ac3) into master (6c5ea4a) will increase coverage by 0.67%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   49.06%   49.73%   +0.67%     
==========================================
  Files         108      115       +7     
  Lines       10428    10977     +549     
==========================================
+ Hits         5116     5459     +343     
- Misses       4200     4351     +151     
- Partials     1112     1167      +55     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
rulesets.go 35.09% <47.36%> (+7.43%) ⬆️
workers_tail.go 52.00% <52.00%> (ø)
workers_subdomain.go 57.14% <57.14%> (ø)
email_routing_settings.go 60.00% <60.00%> (ø)
email_routing_rules.go 65.64% <65.64%> (ø)
lockdown.go 57.69% <66.00%> (+6.94%) ⬆️
email_routing_destination.go 66.25% <66.25%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 06337df into cloudflare:master Aug 17, 2022
@github-actions github-actions bot added this to the v0.47.0 milestone Aug 17, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sodabrew sodabrew deleted the astone/fix-test-content-types branch August 17, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants