zone-lockdown: paginating list response

[tamas-jozsa]

Description

I'm adding pagination for ListZoneLockdowns API. Additionally, I'm bringing Lockdown APIs to a common pattern. Instead of returning ZoneLockdownResponse they will return ZoneLockdown so they are easier to use.

Has your change been tested?

Unit tests are working

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

[github-actions]

changelog detected ✅

[codecov-commenter]

Codecov Report

Merging #1017 (241b43c) into master (6c5ea4a) will increase coverage by 0.18%.
The diff coverage is 66.00%.

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   49.06%   49.24%   +0.18%     
==========================================
  Files         108      112       +4     
  Lines       10428    10560     +132     
==========================================
+ Hits         5116     5200      +84     
- Misses       4200     4232      +32     
- Partials     1112     1128      +16     

Impacted Files	Coverage Δ
access_application.go	76.52% <ø> (ø)
access_bookmark.go	72.44% <ø> (ø)
lockdown.go	57.69% <66.00%> (+6.94%)	⬆️
workers_subdomain.go	57.14% <0.00%> (ø)
workers_account_settings.go	35.71% <0.00%> (ø)
workers_tail.go	52.00% <0.00%> (ø)
r2_bucket.go	100.00% <0.00%> (ø)
filter.go	42.96% <0.00%> (+0.51%)	⬆️
firewall_rules.go	53.98% <0.00%> (+1.39%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jacobbednarz]

instead of introducing a change that takes us further away from the experimental method signatures, let's update it to move towards it.

check out https://github.com/cloudflare/cloudflare-go/blob/master/tunnel.go for an example of where we should head.

[tamas-jozsa]

instead of introducing a change that takes us further away from the experimental method signatures, let's update it to move towards it.

check out https://github.com/cloudflare/cloudflare-go/blob/master/tunnel.go for an example of where we should head.

That's very useful, thanks Jacob! I've opened an issue for further clarifications: 1023

[github-actions]

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!