Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hyperdrive] Issues with error handling in Worker examples #14474

Closed
KianNH opened this issue May 8, 2024 · 0 comments · Fixed by #14480
Closed

[Hyperdrive] Issues with error handling in Worker examples #14474

KianNH opened this issue May 8, 2024 · 0 comments · Fixed by #14480
Assignees
@elithrar @sejoker @thomasgauvin @Maddy-Cloudflare
Labels
bad-example content:edit Request for content edits documentation Documentation edits product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/

Comments

@KianNH
Copy link
Contributor

KianNH commented May 8, 2024

Existing documentation URL(s)

What changes are you suggesting?

These examples attempt to JSON.stringify an Error, which will always result in {}. They should instead do error: e.message.

Additional information

No response
@KianNH KianNH added content:edit Request for content edits documentation Documentation edits labels May 8, 2024
@github-actions github-actions bot added the product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/ label May 8, 2024
@KianNH KianNH mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elithrar elithrar

@sejoker sejoker

@thomasgauvin thomasgauvin

@Maddy-Cloudflare Maddy-Cloudflare

Labels
bad-example content:edit Request for content edits documentation Documentation edits product:hyperdrive Hyperdrive: https://developers.cloudflare.com/hyperdrive/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Hyperdrive] Fix error handling in examples KianNH/cloudflare-docs
6 participants
@elithrar @sejoker @kodster28 @thomasgauvin @KianNH @Maddy-Cloudflare