Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store data with Fauna --> Wrangler 1 to 2 #14418

Closed
Tracked by #7610
kodster28 opened this issue May 6, 2024 · 2 comments · Fixed by #10050
Closed
Tracked by #7610

Store data with Fauna --> Wrangler 1 to 2 #14418

kodster28 opened this issue May 6, 2024 · 2 comments · Fixed by #10050
Assignees
Labels
product:workers Related to Workers product tutorial

Comments

@kodster28
Copy link
Contributor

kodster28 commented May 6, 2024

https://developers.cloudflare.com/workers/tutorials/store-data-with-fauna/: https://github.com/fauna-labs/fauna-workers/blob/master/wrangler.toml contains the redundant type="javascript", and the tutorial references (but doesn't actually use type="webpack").

Likely makes sense to update with Hono as well

@yusukebe
Copy link
Contributor

yusukebe commented May 9, 2024

Hi @kodster28

https://developers.cloudflare.com/workers/tutorials/store-data-with-fauna/

I think this tutorial uses the latest tools - Hono, TypeScript, and Wrangler v3. This refers to https://github.com/yusukebe/fauna-workers instead of https://github.com/fauna-labs/fauna-workers/tree/master. Can you check it?

@kodster28 kodster28 linked a pull request May 21, 2024 that will close this issue
@kodster28
Copy link
Contributor Author

Hi @kodster28

https://developers.cloudflare.com/workers/tutorials/store-data-with-fauna/

I think this tutorial uses the latest tools - Hono, TypeScript, and Wrangler v3. This refers to https://github.com/yusukebe/fauna-workers instead of https://github.com/fauna-labs/fauna-workers/tree/master. Can you check it?

Oh... you're totally right!

You already did this work in #10050. Thanks past @yusukebe for doing the work and present @yusukebe for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product tutorial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants