Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data types of fields in core/mcis/ #991

Open
jihoon-seo opened this issue Nov 26, 2021 · 0 comments
Open

Data types of fields in core/mcis/ #991

jihoon-seo opened this issue Nov 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jihoon-seo
Copy link
Member

What would you like to be enhanced
:

MaxResultNum 라는 필드가 있는데, data type 이 string 입니다.

// McisRecommendReq is struct for McisRecommendReq
type McisRecommendReq struct {
	VmReq          []TbVmRecommendReq `json:"vmReq"`
	PlacementAlgo  string             `json:"placementAlgo"`
	PlacementParam []common.KeyValue  `json:"placementParam"`
	MaxResultNum   string             `json:"maxResultNum"`
}

// TbVmRecommendReq is struct for TbVmRecommendReq
type TbVmRecommendReq struct {
	RequestName  string `json:"requestName"`
	MaxResultNum string `json:"maxResultNum"`

	VcpuSize   string `json:"vcpuSize"`
	MemorySize string `json:"memorySize"`
	DiskSize   string `json:"diskSize"`
	//Disk_type   string `json:"disk_type"`

	PlacementAlgo  string            `json:"placementAlgo"`
	PlacementParam []common.KeyValue `json:"placementParam"`
}

다른 struct에 VmGroupSize 라는 필드도 있는데, 이것도 data type 이 string 입니다.

@seokho-son 이들을 uint8 등으로 바꾸는 것이 어떨까요? 😊
(이 이슈를 쓰면서 보니, 위의 VcpuSize, DiskSizeuint8 등으로, MemorySizefloat32 로 바꿀 수도 있겠네요 😊)

(FYI: TbSpecInfo struct 에서 다양한 data type을 사용하고 있습니다.)

Why is this needed
:

Proposed solution
:

@jihoon-seo jihoon-seo added the enhancement New feature or request label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant