Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance codes for mcis control by applying switchCase #761

Open
seokho-son opened this issue Sep 23, 2021 · 2 comments
Open

Enhance codes for mcis control by applying switchCase #761

seokho-son opened this issue Sep 23, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@seokho-son
Copy link
Member

seokho-son commented Sep 23, 2021

Issued from review comments in PR #760

이 경우처럼 case 가 많은 경우에는
switch-case + fallthrough 로 짜는 것이 더 좋은 것 같기는 합니다.. 😊

Originally posted by @jihoon-seo in #760 (comment)

맞습니다 ㅎㅎ 코드 수정할 때는 생각 못했었는데 지금 다시 보니깐 switch문으로 바꾸는게 좀 더 코드가 이쁠 것 같네요😊
시간될 때 한번 고쳐보겠습니다.

Originally posted by @PARKINHYO in #760 (comment)

@seokho-son seokho-son added the enhancement New feature or request label Sep 23, 2021
@seokho-son
Copy link
Member Author

@PARKINHYO Could you contribute to this issue? :)

@seokho-son
Copy link
Member Author

/assign @PARKINHYO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants