webextension: handler for runtime messages now returns a promise #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
Handling of runtime messages involves asynchronous operations (e.g. injection of stylesheets in frames) which are currently not tied to the return value of the handler. This causes two issues:
console.error
is shown).This PR changes the behavior so that handling of runtime messages returns a promise which can fail. Moreover, different cases of failure now trigger custom error messages so that caller knows why errors are thrown.