Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heapprofiler: how to get around initial boot noise? #460

Open
lassic opened this issue Sep 26, 2023 · 1 comment
Open

heapprofiler: how to get around initial boot noise? #460

lassic opened this issue Sep 26, 2023 · 1 comment

Comments

@lassic
Copy link

lassic commented Sep 26, 2023

when a large server starts, there are usually tons of allocations on boot, which are often less interesting than the baseline that follows.
we need some sort of option to filter out that noise. as I see it there are a few ways to go about this:

  1. allow filtering in the UI by time (probably not easy as flamegraph format has no time axis, maybe flamescope style?)
  2. allow collecting and stopping programmatically on the current process (not by spawning a new process, since then we're back at the same problem)
  3. add a delay option to the profiler so we can at least set some large delay until we're sure the server started.

Thanks!

@RafaelGSS
Copy link
Contributor

I think we could go with the option 3. We already have

  --stop-delay               Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)

So adding a --start-delay seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants