Allow defining template user functions #74
Conversation
pkg/template/template.go
Outdated
| } | ||
| } | ||
|
|
||
| // RegisterFunc registers a named function or overwrites a built-in function. | ||
| // Call this before Parse. | ||
| func (t *Template) RegisterFunc(name string, f func(fields ...interface{}) (string, error)) { |
There was a problem hiding this comment.
Only question I have is should we change this to be Funcs and have the argument be a template.FuncMap to match the text/template package? My vote would be yes to keep consistency with the text/template package since we have been doing that with Parse and Execute. I know I was the one who suggested RegisterFunc in the first place 😞
There was a problem hiding this comment.
I've been trying to think of something along these lines as well. Having written an example for testing, the user ends up having to do a lot of what text/template does internally.
Do we support devs calling RegisterFuncs multiple times and just merge the maps? Last wins, which would be consistent with possibly overriding defaults?
There was a problem hiding this comment.
That is what I was thinking. We support calling Funcs multiple times and just merging the maps where the latest entry for a key wins. That is how Funcs works in text/template.
There was a problem hiding this comment.
@heaths I went ahead and made the changes I suggested. Let me know what you think.
Resolves #73