Extract export package from gh #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
samcoe
commented
Aug 16, 2022
pkg/template/template.go
Outdated
| } | ||
| } | ||
|
|
||
| func (t *Template) Parse(tpl string) error { |
There was a problem hiding this comment.
This is the only change from the cli version of this package. Parse now needs to be explicitly called rather than implicitly being called from within Execute. I made this change to reduce the number of arguments to New and Execute. Additionally, I find the explicitness of it to be easier to follow.
samcoe
commented
Aug 16, 2022
| ) | ||
|
|
||
| // Evaluate a jq expression against an input and write it to an output. | ||
| func Evaluate(input io.Reader, output io.Writer, expr string) error { |
There was a problem hiding this comment.
Open to naming suggestions here? I also changed the argument order to have the input come first compared to the same function in gh.
samcoe
commented
Aug 16, 2022
| return t.tmpl.Execute(t.output, data) | ||
| } | ||
|
|
||
| func (t *Template) Flush() error { |
There was a problem hiding this comment.
This used to be called End but I felt Flush was a more clear representation of what it does.
vilmibm
approved these changes
Aug 16, 2022
| ) | ||
|
|
||
| // Evaluate a jq expression against an input and write it to an output. | ||
| func Evaluate(input io.Reader, output io.Writer, expr string) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts out the
exportpackage fromgh. Functionality wise, there are minimal changes compared to the counterpart packages ingh. After this is merged I will make a follow up PR in cli/cli to use this extracted package.cc cli/cli#5544