Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use retryable HTTP client (for 50x) errors #157

Open
saschagrunert opened this issue Apr 12, 2024 · 0 comments
Open

Use retryable HTTP client (for 50x) errors #157

saschagrunert opened this issue Apr 12, 2024 · 0 comments

Comments

@saschagrunert
Copy link

To make clients like gh more robust, it would be great to have HTTP retries especially on 50x errors. A library like go-retryablehttp could be used for that, but that would be clearly a breaking API change.

Do you have thoughts on that?
saschagrunert added a commit to saschagrunert/packaging that referenced this issue Apr 15, 2024
@saschagrunert
Retry GitHub job watch
90292c6 
From time to time the job watch throws a 502 error:

```
failed to get jobs: HTTP 502: Server Error (https://api.github.com/repos/cri-o/packaging/actions/runs/8682352551/jobs?per_page=100)
```

We now retry up to three times to make the test suite robust. As
follow-up, I opened: cli/go-gh#157

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saschagrunert