Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent rate limiter feedback #6429

Closed
devzer01 opened this issue Oct 12, 2022 · 2 comments
Closed

Inconsistent rate limiter feedback #6429

devzer01 opened this issue Oct 12, 2022 · 2 comments
Labels
bug Something isn't working p3 Affects a small number of users or is largely cosmetic

Comments

@devzer01
Copy link

I have been testing gh run list to understand what's the best way to use it, and all the sudden it just started saying

failed to get runs: HTTP 403 (https://api.github.com/repos/reversead/keywordapp-backend/actions/runs?per_page=20)

i tried numerous times and got the same message, i was suspicious about rate limits but the error didn't mention that it's almost like the page disappeared .

and only when i modify the arguments to the call by adding an extra argument

 gh run list --repo reversead/keywordapp-backend --workflow deploy-dev
⢿couldn't fetch workflows for reversead/keywordapp-backend: HTTP 403: API rate limit exceeded for user ID 4328569. (https://api.github
.com/repos/reversead/keywordapp-backend/actions/workflows?per_page=100&page=1)

then it displayed the correct error messages

I would have gone and try to fix this but the attitude i received on the previous submission has made me lost motivation to contribute any improvements to your project,

@mislav
Copy link
Contributor

mislav commented Oct 13, 2022

Thanks for the report! You are right that the underlying API rate limit exceeded message in the HTTP response was not getting surfaced in the final error message. I've opened a PR in the go-gh library to fix this: cli/go-gh#82

I would have gone and try to fix this but the attitude i received on the previous submission has made me lost motivation to contribute any improvements to your project,

That's okay if you won't fix this yourself. You are welcome to just report a bug and leave it at that.

@mislav mislav added bug Something isn't working p3 Affects a small number of users or is largely cosmetic and removed feedback needs-triage needs to be reviewed labels Oct 13, 2022
@mislav
Copy link
Contributor

mislav commented Oct 18, 2022

Fixed by #6454

@mislav mislav closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p3 Affects a small number of users or is largely cosmetic
Projects
None yet
Development

No branches or pull requests

3 participants