Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put cursor on selected line in PR/issue template selection menu #1085

Closed
shindere opened this issue Jun 3, 2020 · 4 comments
Closed

Put cursor on selected line in PR/issue template selection menu #1085

shindere opened this issue Jun 3, 2020 · 4 comments
Labels
blocked discuss Feature changes that require discussion primarily among the GitHub CLI team enhancement a request to improve CLI

Comments

@shindere
Copy link

shindere commented Jun 3, 2020

At the moment, when running gh pr create or gh issue create displays a menu that lets one select the PRLissue template to use and the selected line in this menu is marked by a ">" sign that appears at the beginning of the line.

This is already usable by a visually impaired person, but it requires some guess work to figure out how the selected line is marked.

Things would be more intuitive if the cursor could be placed on the selected line because screen readers generally follow the cursor.

If this behaviour is considered not suitable by default, there could be a configuration setting that enables it but is turned off by default.

@shindere shindere changed the title Put cursor on selected line in PRlissue template selection menu Put cursor on selected line in PR/issue template selection menu Jun 3, 2020
@shindere
Copy link
Author

shindere commented Jun 3, 2020

This is also true for the Submit / Continue in browser/ Cancelmenu.

@mislav mislav added the enhancement a request to improve CLI label Jun 3, 2020
@vilmibm vilmibm added the blocked label Oct 7, 2020
@vilmibm
Copy link
Contributor

vilmibm commented Oct 7, 2020

This sounds like a great improvement to me; it's something that would currently have to be patched in the prompt library we use, https://github.com/AlecAivazis/survey/ , unfortunately.

@shindere
Copy link
Author

shindere commented Oct 8, 2020 via email

@vilmibm vilmibm self-assigned this May 28, 2021
@vilmibm vilmibm added this to Backlog 🗒 in The GitHub CLI via automation May 28, 2021
@samcoe samcoe added the discuss Feature changes that require discussion primarily among the GitHub CLI team label Apr 7, 2022
@mislav
Copy link
Contributor

mislav commented Apr 13, 2022

This was implemented and shipped with Survey in the meantime. AlecAivazis/survey#358

@mislav mislav closed this as completed Apr 13, 2022
The GitHub CLI automation moved this from Backlog 🗒 to Done 💤 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked discuss Feature changes that require discussion primarily among the GitHub CLI team enhancement a request to improve CLI
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

No branches or pull requests

5 participants
@mislav @vilmibm @shindere @samcoe and others