Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property merging bug #852

Closed
alexlamsl opened this issue Jan 9, 2017 · 3 comments
Closed

Property merging bug #852

alexlamsl opened this issue Jan 9, 2017 · 3 comments

Comments

@alexlamsl
Copy link
Contributor

I was hunting around for #800 when I encounter this bug:

a{
  border-top-color:red;
}
a{
  border-top-width:10px;
}
a{
  border:magenta;
}

... gets optimised into:

a{border:#ff00ff}

Note the missing border-top-width. Happens on both 3.4.23 (default options) and master (with {level:2})

@jakubpawlowicz
Copy link
Collaborator

It's actually as it should be since border shorthand overrides all border styles, see: https://www.w3.org/TR/css3-background/#the-border-shorthands and https://jsfiddle.net/rdfnstad/

Btw, #800 will be solved once aggressive merging is gone. Unless we want to fix in 3.4 too.

@alexlamsl
Copy link
Contributor Author

Ah yes of course I was confusing border with border-color - sorry for the noise!

@jakubpawlowicz
Copy link
Collaborator

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants