Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source-map to 0.7.2 to get speed improvements #1012

Closed
andreicristianpetcu opened this issue Mar 4, 2018 · 4 comments
Closed

Comments

@andreicristianpetcu
Copy link

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

@jakubpawlowicz
Copy link
Collaborator

Sure, we can do it in 4.2.0.

@jakubpawlowicz jakubpawlowicz added this to the 4.2.0 milestone Mar 5, 2018
@realityking
Copy link

Note source-map 0.7 requires Node.js 8

@jakubpawlowicz
Copy link
Collaborator

I planned to drop Node.js 4 in clean-css 5 but there may be a point in dropping Node.js 6 too when Node.js 10 is out so we can use the source-map 0.7.

@jakubpawlowicz jakubpawlowicz modified the milestones: 4.2.0, ~future~ Mar 6, 2018
@jakubpawlowicz jakubpawlowicz removed this from the ~future~ milestone Jan 13, 2021
@jakubpawlowicz
Copy link
Collaborator

Won't fix. I've tried to migrate to source-map 0.7 multiple times and their promise-based API didn't work for me. Closing it as clean-css is going into maintenance mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants