Fix patched module resource lookup #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, on further investigation perhaps it's the |
|
This is a really high-quality PR -- thanks for the work on this and the attention to detail as to how code works in ClassGraph! However, based on your last comment, I'll let you dig a bit further before I merge this. (Sorry, I'm really short on time to help out with this right now...) Please let me know what you figure out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current getURI method constructs a classpath resource from the
getClasspathElementURImethod. This doesn't worked for patched modules that could come from different classpaths (for example the module may start as a jar but have a directory patched in).Calling the
ModuleReader#findmethod (https://docs.oracle.com/javase%2F9%2Fdocs%2Fapi%2F%2F/java/lang/module/ModuleReader.html#find-java.lang.String-) instead will give us the URI of the resource.Might fix #704