Add thrown exceptions to MethodInfo (#633) #637
Conversation
| @@ -318,6 +324,24 @@ public String getTypeSignatureOrTypeDescriptorStr() { | |||
| } | |||
| } | |||
|
|
|||
| public ClassInfoList getThrownExceptions() { | |||
There was a problem hiding this comment.
When a thrown exception is a generic type variable, the Exceptions attribute refers to the bound type, which I think makes sense to return here?
There was a problem hiding this comment.
Yes, I think so, or if all else fails and the type variable cannot be resolved or does not have a supertype (e.g. E extends IOException), just return Exception as the concrete type, I think.
It's a shame Java doesn't have union types, since it would be nice to return TypeVariable or ClassInfo depending on whether or not the class variable is unresolved.
Also you can discard type parameters like T in MyException<T>. If anyone needs those, they can use the existing method to get the generic throws type signature.
There was a problem hiding this comment.
Also you can discard type parameters like T in MyException
I believe that is how this functions currently.
jkschneider
force-pushed
the
thrown-exceptions
branch
from
8e41367
to
abe691d
Compare
jkschneider
force-pushed
the
thrown-exceptions
branch
from
abe691d
to
441eb02
Compare
| thrownExceptions = new ClassInfoList(thrownExceptionNames.length); | ||
| for (String thrownExceptionName : thrownExceptionNames) { | ||
| ClassInfo classInfo = scanResult.getClassInfo(thrownExceptionName); | ||
| thrownExceptions.add(classInfo); |
There was a problem hiding this comment.
classInfo may be null here -- is it helpful to have a null placeholder in the list for classes that could not be found (because they were not discovered during the scan)?
Actually I forgot one more change you should make -- look at extendScanningUpwards() -- you should schedule the thrown exceptions for scanning in that method. If you make this change, the chance of classInfo being null is lower, because any named exceptions will be scanned as "external classes" even if they are not in the accept list.
That raises the question though, is the Exception attribute always present, even if there is a generic throws type signature present?
There was a problem hiding this comment.
That raises the question though, is the Exception attribute always present, even if there is a generic throws type signature present?
Yes it is. The Exception attribute will return the bound type though. So it just kind of works as is without having to strip parameterizations and such off of throws.
There was a problem hiding this comment.
is it helpful to have a null placeholder in the list for classes
Null values removed in the latest commit.
jkschneider
force-pushed
the
thrown-exceptions
branch
from
316a769
to
02907da
Compare
jkschneider
force-pushed
the
thrown-exceptions
branch
from
02907da
to
f731358
Compare
|
Looks good to me. Thanks for all your work on this! Will merge now. |
|
I'm working on another bugfix, which might take a couple of days to sort out, but I'll push this out in a new version as soon as I can. Thanks for your patience, I'm swamped right now! |
No worries, and thanks for your incredible responsiveness. |
No description provided.