Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks Directory #275

Open
groadabike opened this issue Apr 5, 2023 · 2 comments
Open

Notebooks Directory #275

groadabike opened this issue Apr 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@groadabike
Copy link
Contributor

@jonbarker68,
In Notebooks we have tutorials that are specific for CEC2. I also have some tutorials in the CAD1 recipe.

We need to organise this:

  1. Have Google Colab tutorials in the readme of each challenge
  2. Move all tutorials to the notebooks directory

I would remove the jupyter files and only have a README with Google Colab links
What do you think?

@groadabike groadabike added bug Something isn't working question Further information is requested labels Apr 5, 2023
@groadabike groadabike self-assigned this Apr 5, 2023
@jonbarker68
Copy link
Contributor

jonbarker68 commented Apr 6, 2023

@groadabike
I prefer to distribute the tutorials along with the repository on GitHub.

This has several advantages over storing them on colab

  • All the source remains in one place,
  • They are under version control -- so easy to maintain, eg. when we make breaking changes to the library
  • They can be tested and formatted with the precommit hooks
  • People may want to run them locally anyway, i.e. they'll have local copies when pip -e installing

Storing in GitHub does not prevent easy Colab integration. i.e. Notebooks stored in github can be opened in collab with eg.

https://colab.research.google.com/github/claritychallenge/clarity/blob/master/notebooks/01_Installing_clarity_tools_and_using_metadata.ipynb

For example, see here https://claritychallenge.org/tutorials

Actions

  • I agree that these should be linked in the READMEs
  • The Cadenza tutorial should also be on the Cadenza website - feel free to reuse the Docusaurus code that we wrote for the Clarity site ... inspired by the Speechbrain tutorials)
  • The cadenza tutorials should be committed to the repo and the references in the READMEs can provide links to open them on Colab
  • The repositories notebooks/ dir should be reorganised to reflect the repo, e.g.

notebooks/recipes/cad1
notebooks/recipes/cec2

Later we may also introduce non recipes based tutorials, e.g.
notebooks/tutorials/using_the_enhancers
notebooks/tutorials/using_the_evaluators

  • One small downside: the links for opening on colab use the github path and so change when we reorganise the repo. This means website that use the link need updating if the repo directory structure is reorganised. But if we get that right now it shouldn't have to change again in the future

  • (NB: I've decided that we should move the recipes dir under the clarity dir -- maintaining two parallel package directories at the top level is causing a lot of complication. e.g. we've missed the fact that the recipes code is not under pytest coverage ... currently dealing with this in PR Tests for recipes #270. Does notebooks/ also belong under clarity? It probably does if we want them to be installed when people run pip install -e)

@groadabike groadabike added enhancement New feature or request and removed bug Something isn't working labels Apr 6, 2023
@groadabike
Copy link
Contributor Author

groadabike commented Apr 6, 2023

@jonbarker68 ,

Storing in GitHub does not prevent easy Colab integration. i.e. Notebooks stored in github can be opened in collab with eg.

https://colab.research.google.com/github/claritychallenge/clarity/blob/master/notebooks/01_Installing_clarity_tools_and_using_metadata.ipynb

Oh!, I didn't know about this, very cool. I like it better now. No need to save a copy of the notebooks in colab.

notebooks/recipes/cad1
notebooks/recipes/cec2

Later we may also introduce non recipes based tutorials, e.g.
notebooks/tutorials/using_the_enhancers
notebooks/tutorials/using_the_evaluators

Yeah, I like this distribution of the tutorials, then, in tutorial/README.md we can add links to all of the turorials, e.g., organised with a table.

Does notebooks/ also belong under clarity? It probably does if we want them to be installed when people run pip install -e)

Good question. what would be the advantage of installing them with pip install -e? Most people will clone the repo before installing it, right? If that is the case, they will download the tutorial.


btw, I am working on fixing some issues with task1. Should I wait for PR #270 to be merged before submitting mine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants