fix(derive): Allow clippy::almost_swapped
#4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
changed the title
gen_augmentgen_augment
rkrasiuk
force-pushed
the
rkrasiuk/fix-almost-swapped-lint
branch
from
7229ca6
to
c1caf46
Compare
epage
reviewed
Feb 27, 2023
rkrasiuk
force-pushed
the
rkrasiuk/fix-almost-swapped-lint
branch
from
c1caf46
to
322b813
Compare
rkrasiuk
changed the title
gen_augmentclippy::almost_swapped
rkrasiuk
force-pushed
the
rkrasiuk/fix-almost-swapped-lint
branch
from
322b813
to
872135b
Compare
epage
reviewed
Feb 27, 2023
|
Thanks! |
This was referenced Feb 28, 2023
2 tasks
hds
added a commit
to hds/clap
that referenced
this pull request
Apr 27, 2023
As of Rust 1.69, the `clippy::almost_swapped` lint was enhanced and now triggers on certain derive macros inside clap. To avoid the need for the user to allow these lints outside of the macro (which generally requires a module level `allow`), the allow was added to the generated code for the v4 branch in clap-rs#4735. This change backports that fix the the `v3-master` branch. Fixes: clap-rs#4857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4733