fix(help): Don't accidentally show long help with --help when it isn't intended.
#4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-my-profile
force-pushed
the
fix-help-text-for-edge-case
branch
from
de8a410
to
a1ca459
Compare
not-my-profile
force-pushed
the
fix-help-text-for-edge-case
branch
from
a1ca459
to
1f618a7
Compare
not-my-profile
added a commit
to not-my-profile/ruff
that referenced
this pull request
Feb 15, 2023
For example:
$ ruff check --select=EM<Tab>
EM -- flake8-errmsg
EM10 EM1 --
EM101 -- raw-string-in-exception
EM102 -- f-string-in-exception
EM103 -- dot-format-in-exception
(You will need to enable autocompletion as described
in the Autocompletion section in the README.)
Fixes astral-sh#2808.
(The --help help change in the README is due to a clap bug,
for which I already submitted a fix:
clap-rs/clap#4710.)
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Feb 15, 2023
For example:
$ ruff check --select=EM<Tab>
EM -- flake8-errmsg
EM10 EM1 --
EM101 -- raw-string-in-exception
EM102 -- f-string-in-exception
EM103 -- dot-format-in-exception
(You will need to enable autocompletion as described
in the Autocompletion section in the README.)
Fixes #2808.
(The --help help change in the README is due to a clap bug,
for which I already submitted a fix:
clap-rs/clap#4710.)
epage
changed the title
--help when it isn't intended.
epage
changed the title
--help when it isn't intended.--help when it isn't intended.
|
Thanks! |
|
Released |
|
Thanks for the quick release :) I am afraid I missed that there were actually two bugs ... opened #4712 for the second one. |
not-my-profile
added a commit
to not-my-profile/ruff
that referenced
this pull request
Feb 15, 2023
My two clap bug fixes[1][2] have been merged and released (see the change in README.md). [1]: clap-rs/clap#4710 [2]: clap-rs/clap#4712
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Feb 15, 2023
My two clap bug fixes[1][2] have been merged and released (see the change in README.md). [1]: clap-rs/clap#4710 [2]: clap-rs/clap#4712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally showing long help just because a hidden argument had a description for a possible value. This is most likely to be hit with the derive API as the value descriptions are automatically applied from documentation.