Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Speed up compiling arg! macro #4673

Merged
merged 1 commit into from Jan 24, 2023
Merged

perf: Speed up compiling arg! macro #4673

merged 1 commit into from Jan 24, 2023

Conversation

epage
Copy link
Member

@epage epage commented Jan 24, 2023

To "append" calls, we were passing in a more and more complex expression on each recursive invocation. We now pass in a fixed amount of data on each iteration, reducing how much the macro machinery needs to parse, speeding up builds.

Fresh builds went from 39s to 32s on my machine.

Inspired by #4670

To "append" calls, we were passing in a more and more complex expression
on each recursive invocation.  We now pass in a fixed amount of data on
each iteration, reducing how much the macro machinery needs to parse,
speeding up builds.

Fresh builds went from 39s to 32s on my machine.

Inspired by clap-rs#4670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant