Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make cmd variable (bash completion) local #4663

Merged
merged 2 commits into from Jan 23, 2023
Merged

fix: Make cmd variable (bash completion) local #4663

merged 2 commits into from Jan 23, 2023

Conversation

fredrik-jansson-se
Copy link

Fix for the generation bash completion script, the cmd variable should be local, cmds was probably a typo.

@fredrik-jansson-se
Copy link
Author

Not sure why the lint commits/lint commits (PR) failed, happy to fix if someone can explain what needs to be fixed :)

@epage
Copy link
Member

epage commented Jan 23, 2023

Not sure why the lint commits/lint commits (PR) failed, happy to fix if someone can explain what needs to be fixed :)

The error is:

4c8ac00: error Commit is not in Conventional format: Missing type in the commit summary, expected `type: description`

which is based on https://www.conventionalcommits.org/en/v1.0.0/

but the log also says:

If this fails, don't sweat it. We're trying to encourage clear communication and not hinder contributions.
If it is a reasonable issue and you lack time or feel uncomfortable fixing it yourself,
let us know and we can mentor or fix it.

@fredrik-jansson-se
Copy link
Author

fredrik-jansson-se commented Jan 23, 2023

@epage, thanks, I fixed the commit message now. I'll fix the minimal test.

@fredrik-jansson-se fredrik-jansson-se changed the title Make cmd variable (bash completion) local fix: Make cmd variable (bash completion) local Jan 23, 2023
@epage epage merged commit 930a40c into clap-rs:master Jan 23, 2023
@epage
Copy link
Member

epage commented Jan 23, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants