fix: wasm32 targets with is-terminal #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
force-pushed
the
fix-wasm32-attempt2
branch
from
10c92aa
to
1ae6f4c
Compare
This was referenced Nov 29, 2022
|
Builds fine - CI is now blocked on testing issues: #4510 (comment) |
|
I pulled #4515 out of this so we don't block fixing production code based on tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4510
Note:
terminal_sizeis using old version of rustix and this causes a bit dependency duplication.Will check to bump upstream. EDIT: Someone already did - eminence/terminal-size#46 (needs a release)