Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Allow defaults for Help/Version #4330

Merged
merged 1 commit into from Oct 1, 2022
Merged

Conversation

epage
Copy link
Member

@epage epage commented Oct 1, 2022

These didn't make sense for the builder but are helpful for the derive. The assert was assuming people wouldn't do this and to catch internal problems.

Fixes #4326

These didn't make sense for the builder but are helpful for the derive.
The assert was assuming people wouldn't do this and to catch internal
problems.

Fixes clap-rs#4326
@epage epage merged commit cc0da32 into clap-rs:master Oct 1, 2022
@epage epage deleted the assert branch October 1, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

making custom help optional with default_value_t panicks
1 participant